End in slash parent directory location #18178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findinpath
commented
Jul 7, 2023
| @@ -197,7 +197,7 @@ public Location parentDirectory() | |||
| return withPath(newLocation, ""); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I'd be inclined to allow calling this method for non-filename locations as well.
The required changes should probably be straightforward.
I'm not sure though whether it is needed.
In a table with multiple partition columns, it may happen that there exists a file with the same name and the same value for the least significant partition column which would lead to having the same temporary file name prefix.
findinpath
force-pushed
the
findinpath/alternative-location-parent-directory
branch
from
5c89fa4 to
e022ef3
Compare
|
I'm abandoning doing the changes on this PR because the purpose itself of the PR is rather controversial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed on #18155 (comment) the parent directory location of a file name should be ending in
/e.g. : The location
scheme://userInfo@host/path/filenamewill return forLocation.parentDirectory()method the following resultscheme://userInfo@host/path/Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: